-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
escaping the \ character in the file path #16
Comments
Since I don't have Windows machine to test the output, I try to blind fix this on branch |
Forward slash is working in Windows as well. Must not be a problem since Windows Vista |
@shuLhan You can grab a windows VM from Microsoft at https://developer.microsoft.com/en-us/microsoft-edge/tools/vms/. They're intended for browser testing, but I've not seen any restrictions on installing other software. Windows has supported both slashes as path separators for a very long time (back in the early DOS days). The dev branch worked for me with the exception that it required a directory component for the output file: Lines 226 to 231 in 4ec947e
It looks like this might be part of a new mechanism for handling the output, but it breaks the existing scenario where the output is defined to be a single file. |
I have installed Windows in virtual machine just to test and try to fix this bug but I can't reproduce it. Can you give more information about error message, list of files in your |
@SQLServerIO Can you please try again with latest version. Thank you. |
On Windows the file paths are normally \ and not / and when you include a directory it generates code that will not build.
My example:
go-bindata -ignore=\*.bak -o assets.go scripts\
in my assets.go file I end up with scripts\file name and that throws an error due to the unescaped
in release.go the offending line is
info := bindataFileInfo{name: %q, size: %d, mode: os.FileMode(%d), modTime: time.Unix(%d, 0)}
I'm assuming that %q needs to be sanitized.
The text was updated successfully, but these errors were encountered: