Expose Score enum

[tmpfs]

I noticed upgrading from 2.2.2 to 3.0 that the Score (which used to be u8) is private.

This breaks my usage of this library so I just exported Score to be public.

I can't see any reason to keep Score private as it's exposed in Entropy, I guess this is an oversight with the refactor?

[tmpfs]

Also out of curiosity why are you converting to i8 for Score when all the enum variants are unsigned and you used u8 before?

[tmpfs]

I should have put it in another PR but I also derived Deserialize for Score and I think it would be worth doing for all types when feature is ser - what do you think? Can split into a separate PR if you prefer.

[shssoichiro]

Thanks, just one question, this looks good. I'm surprised the compiler didn't complain about Score being private, it shouldn't be possible if it's exposed in Entropy which is public.

[tmpfs]

Thanks, just one question, this looks good. I'm surprised the compiler didn't complain about Score being private, it shouldn't be possible if it's exposed in Entropy which is public.

Indeed this is a little surprising, I am not sure why this happened; maybe a nuance of the compiler heuristics I don't fully understand 🤷

Is this ok now with the serde fix?

[shssoichiro]

Yes, thank you! I'll put out a 3.0.1 with this asap.