Change feedback to return Option<&Feedback> #73
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
Entropy::feedback()
function to returnOption<&Feedback>
instead of&Option<Feedback>
. This makes the API significantly easier to use asOption<&...>
implementsCopy
and it's also more accurate, semantically.Say I want to call map on the return value of the function:
This results in an error with
&Option<Feedback>
:Using
Option<&Feedback>
makes this compile without any errors.