Change feedback to return Option<&Feedback> (#73) #58
zxcvbn.yml
on: push
clippy-rustfmt
24s
build-wasm
1m 29s
Matrix: build
Annotations
34 warnings
casting to the same type is unnecessary (`u64` -> `u64`):
src/scoring.rs#L941
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/scoring.rs:941:31
|
941 | ... * (*scoring::KEYBOARD_STARTING_POSITIONS
| _________________________^
942 | | ... * scoring::KEYBOARD_AVERAGE_DEGREE.pow(j as u32))
943 | | ... as u64
| |________________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
help: try
|
941 ~ * (*scoring::KEYBOARD_STARTING_POSITIONS
942 + * scoring::KEYBOARD_AVERAGE_DEGREE.pow(j as u32))
|
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/scoring.rs#L924
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/scoring.rs:924:39
|
924 | assert_eq!(p.estimate(token), base_guesses as u64);
| ^^^^^^^^^^^^^^^^^^^ help: try: `{ base_guesses }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
|
casting to the same type is unnecessary (`u64` -> `u64`):
src/scoring.rs#L892
warning: casting to the same type is unnecessary (`u64` -> `u64`)
--> src/scoring.rs:892:39
|
892 | assert_eq!(p.estimate(token), base_guesses as u64);
| ^^^^^^^^^^^^^^^^^^^ help: try: `{ base_guesses }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
casting the result of `i32::abs()` to u64:
src/scoring.rs#L864
warning: casting the result of `i32::abs()` to u64
--> src/scoring.rs:864:19
|
864 | 365 * (*scoring::REFERENCE_YEAR - p.year).abs() as u64
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(*scoring::REFERENCE_YEAR - p.year).unsigned_abs()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned
|
casting the result of `i32::abs()` to u64:
src/scoring.rs#L829
warning: casting the result of `i32::abs()` to u64
--> src/scoring.rs:829:13
|
829 | (*scoring::REFERENCE_YEAR - 1972).abs() as u64
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(*scoring::REFERENCE_YEAR - 1972).unsigned_abs()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned
= note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default
|
manual `RangeInclusive::contains` implementation:
src/scoring.rs#L536
warning: manual `RangeInclusive::contains` implementation
--> src/scoring.rs:536:16
|
536 | if n >= 63 && n <= 100 {
| ^^^^^^^^^^^^^^^^^^^ help: use: `(63..=100).contains(&n)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
= note: `#[warn(clippy::manual_range_contains)]` on by default
|
used `assert_eq!` with a literal bool:
src/matching/mod.rs#L1211
warning: used `assert_eq!` with a literal bool
--> src/matching/mod.rs:1211:9
|
1211 | assert_eq!(p.ascending, false);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
help: replace it with `assert!(..)`
|
1211 - assert_eq!(p.ascending, false);
1211 + assert!(!p.ascending);
|
|
used `assert_eq!` with a literal bool:
src/matching/mod.rs#L1085
warning: used `assert_eq!` with a literal bool
--> src/matching/mod.rs:1085:13
|
1085 | assert_eq!(p.l33t, true);
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
help: replace it with `assert!(..)`
|
1085 - assert_eq!(p.l33t, true);
1085 + assert!(p.l33t);
|
|
used `assert_eq!` with a literal bool:
src/matching/mod.rs#L1066
warning: used `assert_eq!` with a literal bool
--> src/matching/mod.rs:1066:13
|
1066 | assert_eq!(p.l33t, true);
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
help: replace it with `assert!(..)`
|
1066 - assert_eq!(p.l33t, true);
1066 + assert!(p.l33t);
|
|
used `assert_eq!` with a literal bool:
src/matching/mod.rs#L993
warning: used `assert_eq!` with a literal bool
--> src/matching/mod.rs:993:13
|
993 | assert_eq!(p.reversed, true);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison
= note: `#[warn(clippy::bool_assert_comparison)]` on by default
help: replace it with `assert!(..)`
|
993 - assert_eq!(p.reversed, true);
993 + assert!(p.reversed);
|
|
clippy-rustfmt
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy-rustfmt
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
clippy-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
clippy-rustfmt
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build-wasm
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1, jetli/[email protected]. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build-wasm
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, jetli/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build-wasm
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build-wasm
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build-wasm
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build-wasm
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
build (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
build (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|