Binary deserialization, CCON + TypedArray #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jareguo
commented
Jul 14, 2021
| @@ -437,21 +434,11 @@ class _Deserializer { | |||
| this._onDereferenced = null!; | |||
| } | |||
|
|
|||
| public deserialize (serializedData: SerializedData | CCON) { | |||
| let jsonObj: SerializedData; | |||
| if (serializedData instanceof CCON) { | |||
jareguo
commented
Jul 14, 2021
| @@ -262,29 +260,33 @@ export declare namespace deserialize.Internal { | |||
| } | |||
|
|
|||
| interface DataTypes { | |||
| [DataTypeID.SimpleType]: number | string | boolean | null | object; | |||
| [DataTypeID.SimpleType]: number | string | boolean | null | unknown; | |||
jareguo
commented
Jul 14, 2021
| DataTypeID.Dict | ||
| DataTypeID.Dict | | ||
| DataTypeID.TypedArray | | ||
| DataTypeID.TypedArrayRef |
There was a problem hiding this comment.
引擎侧默认支持反序列化复用 TypedArray，编辑器侧感觉不太需要实现
jareguo
commented
Jul 14, 2021
| function parseTypedArray (data: IFileData, owner: any, key: string, value: ITypedArrayData) { | ||
| const Type = TypedArrays[value[value.length - 1]]; | ||
| value.length -= 1; | ||
| owner[key] = Type.from(value); |
jareguo
commented
Jul 14, 2021
|
|
||
| function parseTypedArrayRef (data: IFileData, owner: any, key: string, value: ITypedArrayRefData) { | ||
| const Type = TypedArrays[value[TYPEDARRAY_REF_TYPE_INDEX]]; | ||
| const chunk = (data[File.Context] as IContext)._mainBinChunk!; |
There was a problem hiding this comment.
获取当前反序列化的上下文，类似 dynamic deserializer 的 this
jareguo
commented
Jul 14, 2021
| @@ -1113,12 +1145,13 @@ export function hasNativeDep (data: IFileData): boolean { | |||
| } | |||
|
|
|||
| function getDependUuidList (json: IFileData): string[] { | |||
| const sharedUuids = json[File.SharedUuids]; | |||
| return json[File.DependUuidIndices].map((index) => sharedUuids[index]); | |||
| assertIsTrue(hasNativeDep(json)); | |||
jareguo
commented
Jul 14, 2021
| @@ -1158,6 +1191,7 @@ if (EDITOR || TEST) { | |||
| }; | |||
| deserialize._BuiltinValueTypes = BuiltinValueTypes; | |||
| deserialize._serializeBuiltinValueTypes = serializeBuiltinValueTypes; | |||
| deserialize._TypedArrays = TypedArrays; | |||
jareguo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine part.