Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use /api/js endpoint as new primary endpoint for server list fetching #63

Merged
merged 3 commits into from
Feb 20, 2022

Conversation

redradrat
Copy link
Contributor

Switched to using https://www.speedtest.net/api/js/servers?engine=js&limit=10 as primary server list request.

This fixes #50.

@r3inbowari
Copy link
Collaborator

r3inbowari commented Dec 1, 2021

Thank you

As mentioned in #50. With time goes by, more and more new speedtest hosts are deployed with higher versions, so it is difficult to obtain close-range and compatible servers in some areas.

This api is obviously better than the original one. But I think the current version is not suitable for using it as the primary endpoint in this time due to some possible compatibility issues.

Because most of the server versions fetched by this api are newer than speedtest-go client, it will cause ping, upload, download to be abnormal when using these new servers. such as negative rate or unable to ping. Because the ping function has been implemented by websocket in the new official version of the server.

lisa added a commit to lisa/speedtest-go that referenced this pull request Feb 18, 2022
Applying showwin#63 to test locally

Signed-off-by: Lisa Seelye <[email protected]>
@showwin
Copy link
Owner

showwin commented Feb 20, 2022

@redradrat Thank you for a great PR 👍
and
@r3inbowari Thank you for great support 🤝

I read an official document about How To Install & Submit Server, and I created testing server in my local based on OoklaServer Installation - Linux / Unix document.
Then it seems the latest server has a compatibility to our speedtest-go client.

So I accept @redradrat idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong server list is returned
3 participants