Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Popover component #51

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Add Popover component #51

wants to merge 13 commits into from

Conversation

stormwarning
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 13, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3565961

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

stormwarning
stormwarning commented Nov 22, 2021
View reviewed changes
addon/components/popover/panel/index.ts

event.preventDefault();
event.stopPropagation();
closePopover();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This internal action calls the closePopover argument function, which in turn updates the value of isOpen.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this affects anything that you are working with right now but shouldn't this be this.args.closePopover()?

Copy link
Contributor Author

@stormwarning stormwarning Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's destructured off of this.args a few lines up, but I'll see if it makes a difference...

NARRATOR: It didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elidupuis elidupuis elidupuis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stormwarning @elidupuis