KafkaSinkCluster: Support new consumer protocol #1825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
force-pushed
the
consumer_protocol
branch
2 times, most recently
from
69c32db
to
c4178d6
Compare
CodSpeed Performance ReportMerging #1825 will not alter performanceComparing Summary
|
rukai
force-pushed
the
consumer_protocol
branch
from
c4178d6
to
4f6169a
Compare
ronycsdu
approved these changes
Nov 20, 2024
justinweng-instaclustr
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kafka is introducing a new consumer group protocol, at the moment nothing uses it, but having now researched it its fairly straightforward to implement, so lets do so.
Details:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-848:+The+Next+Generation+of+the+Consumer+Rebalance+Protocol#KIP848:TheNextGenerationoftheConsumerRebalanceProtocol-ConsumerGroupHeartbeatAPI
But the TL;DR is just that there is a new message type
ConsumerGroupHeartbeatthat we need to route to the group coordinator.To actually test the message type we need to set a broker config to enable this functionality as a kind of "early access", since we already have a kafka 3.9 specific test case, I added this config to the kakfa 3.9 test and added a specific test case to the 3.9 test, to test the new consumer protocol.