KafkaSinkCluster: route DescribeLogDirs request #1823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rukai
changed the title
rukai
changed the title
rukai
force-pushed
the
describe_log_dirs
branch
from
bb40608
to
60f18c3
Compare
CodSpeed Performance ReportMerging #1823 will not alter performanceComparing Summary
|
rukai
force-pushed
the
describe_log_dirs
branch
4 times, most recently
from
ca16a20
to
87f79e5
Compare
rukai
force-pushed
the
describe_log_dirs
branch
from
87f79e5
to
ced406b
Compare
justinweng-instaclustr
approved these changes
Nov 20, 2024
conorbros
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements routing for
DescribeLogDirs.When the java driver routes
DescribeLogDirsit sends it to a broker specified by the user.When
kafka-log-dirs.shroutesDescribeLogDirsit sends an identical request to every node in the cluster.To handle this type of broadcast request shotover routes the request to all nodes in the rack. For other examples look at ListGroups, ListTransactions etc.
We route the request to all nodes in shotover's rack and then combine the results.
We alter the log dir path to avoid collisions with results from other racks, the new path looks like
actual-kafka-broker-id3:/original/log/dir/path.For more details on the reasoning behind this, look at the comment on
fn prepend_destination_to_log_dir.