Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaSinkCluster: route DescribeTransactions requests #1818

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

rukai
Copy link
Member

@rukai rukai commented Nov 15, 2024

another split message type.
It follows the same logic as AddPartitionsToTxn version > 3 message type, where we route and split by transaction id.

The integration tests are following the same pattern as DescribeGroups: https://github.com/shotover/shotover-proxy/pull/1816/files

Copy link

codspeed-hq bot commented Nov 15, 2024

CodSpeed Performance Report

Merging #1818 will not alter performance

Comparing rukai:describe_transactions (642a5e4) with main (819f88c)

Summary

✅ 38 untouched benchmarks

@rukai rukai marked this pull request as ready for review November 15, 2024 06:51
@rukai rukai merged commit 3a37288 into shotover:main Nov 18, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants