-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ins 33065 update docker compose for valkey #1809
Conversation
CodSpeed Performance ReportMerging #1809 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good, just two comments and then we should be good to merge.
shotover-proxy/tests/test-configs/redis/cluster-auth/docker-compose.yaml
Outdated
Show resolved
Hide resolved
….2.5 to valkey-cluster:7.2.5-debian-12-r4
…github.com/shotover/shotover-proxy into INS-33065-update-docker-compose-for-valkey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Updated the docker_compose files in integration tests to use Valkey instead of redis.
Note: For backward compatibility testing,
shotover-proxy/tests/test-configs/redis/passthrough/docker-compose.yaml
has not been changed to keep the test that useslibrary/redis:5.0.9
.