Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements routing for ListTransactions requests by applying the same routing logic to ListTransactions as we did for ListGroups in #1790
However, I found that while the java driver deduplicates entries in ListGroups responses it does not do the same for ListTransactions responses.
So I had to alter the logic in
split_request_by_routing_to_all_brokers
to avoid duplicates.As a result ListGroups is actually more efficient as we better distribute the load across shotover instances by avoiding querying the same node twice.
The comment on
split_request_by_routing_to_all_brokers
explains the new logic pretty well: