Allow passing config path as argument, create setup.py #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function _getConfigPath is too magical, for custom setups it is easiest and most explicit to allow passing the config path as an argument. Add a setup.py to turn directory into package
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -0,0 +1,13 @@ | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| setup(name='shotgunEvents', | |||
| @@ -0,0 +1,13 @@ | |||
| from setuptools import setup, find_packages | |||
There was a problem hiding this comment.
'setuptools.find_packages' imported but unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows passing the config path into the daemon constructor, instead of obtaining it inside. It can also be passed as a command-line argument.
This permits more freedom in composing the config. Also, our own package can depend on it, by having a setup.py and being able to install it.