feat(shorebird_cli): shorebird login verifies user
#297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
approved these changes
Apr 17, 2023
| @@ -170,19 +180,15 @@ class Auth { | |||
| } | |||
|
|
|||
| extension on oauth2.AccessCredentials { | |||
| String get email { | |||
| String? get email { | |||
There was a problem hiding this comment.
I don't have the context to know, but should be be obscuring the fact that this is an email here? e.g. just treating it like an opaque identifier?
There was a problem hiding this comment.
This is currently used to extract the email from the claims so that we can include the user's email in the output of commands like shorebird account or shorebird login (when they're already logged in). This code will have to be refactored once we support multiple OAuth providers 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shorebird loginverifies userType of Change