Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update plist parser to handle comments #2760

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

bryanoltman
Copy link
Contributor

@bryanoltman bryanoltman commented Jan 14, 2025

Description

Updates the propertylistserialization to a version which contains a bug fix for plists containing comments.

This landed in electricbolt/dart-propertylistserialization#5

Fixes #2756

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman bryanoltman changed the title fix: use fork of plist parser to handle comments fix: update plist parser to handle comments Jan 14, 2025
@bryanoltman bryanoltman merged commit c61a08e into main Jan 14, 2025
11 checks passed
@bryanoltman bryanoltman deleted the bo/update-plist-package branch January 14, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shorebird release fails with entitlement validation exception when there are comments in the plist
2 participants