feat(shorebird_code_push_protocol): Add email field to User #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
reviewed
Apr 11, 2023
| @@ -19,6 +23,9 @@ class User { | |||
| /// The unique user identifier. | |||
| final int id; | |||
|
|
|||
| /// The user's email address, as provided by the user during signup. | |||
| final String email; | |||
There was a problem hiding this comment.
Why do we need to expose this atm?
|
Closing based on our discussion since it doesn’t appear to be necessary at this time. |
|
Reopening to support subscription cancellation |
felangel
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an
emailfield to User so we can expose the existing db column.Type of Change