feat(shorebird_cli): add custom keystore support to `shorebird preview` #2740

felangel · 2025-01-03T18:18:05Z

Description

This PR makes it possible to pass a custom keystore configuration when previewing android releases.

Sample Usage

shorebird preview --platform android --release-version 1.0.0+1 --ks=./my_keystore.jks --ks-pass=pass:top-secret --ks-alias=keyAlias

✨ New feature (non-breaking change which adds functionality)
🛠️ Bug fix (non-breaking change which fixes an issue)
❌ Breaking change (fix or feature that would cause existing functionality to change)
🧹 Code refactor
✅ Build configuration change
📝 Documentation
🗑️ Chore
🧪 Tests

packages/shorebird_cli/lib/src/commands/preview_command.dart

codecov · 2025-01-03T18:26:10Z

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

feat(shorebird_cli): add custom keystore support to shorebird preview

b2631d5

felangel requested review from eseidel and bryanoltman January 3, 2025 18:18

felangel self-assigned this Jan 3, 2025

tweak

9a35785

bryanoltman reviewed Jan 3, 2025

View reviewed changes

packages/shorebird_cli/lib/src/commands/preview_command.dart Show resolved Hide resolved

bryanoltman reviewed Jan 3, 2025

View reviewed changes

packages/shorebird_cli/lib/src/commands/preview_command.dart Show resolved Hide resolved

bryanoltman approved these changes Jan 3, 2025

View reviewed changes

felangel enabled auto-merge (squash) January 3, 2025 18:23

felangel merged commit ce2b9eb into main Jan 3, 2025
10 checks passed

felangel deleted the feat/shorebird-preview-keystore branch January 3, 2025 18:25