Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(shorebird_cli): macos preview stream logs #2688

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

felangel
Copy link
Contributor

Description

  • feat(shorebird_cli): macos preview stream logs

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

@felangel felangel self-assigned this Dec 16, 2024
Copy link
Contributor

@bryanoltman bryanoltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough! Does this capture engine and updater logs? I recall an issue where FML logs were not shown in Console output. Curious if that applies here.

@felangel
Copy link
Contributor Author

Simple enough! Does this capture engine and updater logs? I recall an issue where FML logs were not shown in Console output. Curious if that applies here.

It doesn't appear to capture all logs but I assumed those are changes we needed to make at the engine layer.

An example of the logs:

[INFO:flutter/shell/common/shorebird/shorebird.cc(158)] Shorebird updater: active path: /Users/felix/Library/Containers/com.example.sample/Data/Library/Application Support/shorebird/shorebird_updater/patches/1/dlc.vmcode

[INFO:flutter/shell/common/shorebird/shorebird.cc(194)] Starting Shorebird update

2024-12-16 14:25:42.989 sample[61153:55017170] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@bryanoltman
Copy link
Contributor

Simple enough! Does this capture engine and updater logs? I recall an issue where FML logs were not shown in Console output. Curious if that applies here.

It doesn't appear to capture all logs but I assumed those are changes we needed to make at the engine layer.

An example of the logs:

[INFO:flutter/shell/common/shorebird/shorebird.cc(158)] Shorebird updater: active path: /Users/felix/Library/Containers/com.example.sample/Data/Library/Application Support/shorebird/shorebird_updater/patches/1/dlc.vmcode

[INFO:flutter/shell/common/shorebird/shorebird.cc(194)] Starting Shorebird update

2024-12-16 14:25:42.989 sample[61153:55017170] WARNING: Secure coding is automatically enabled for restorable state! However, not on all supported macOS versions of this application. Opt-in to secure coding explicitly by implementing NSApplicationDelegate.applicationSupportsSecureRestorableState:.

Yep, was just curious

@felangel felangel merged commit 11cef95 into main Dec 16, 2024
11 checks passed
@felangel felangel deleted the feat/shorebird-cli-macos-preview-stream-logs branch December 16, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants