chore(shorebird_cli): bump shorebird engine revision #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eseidel
reviewed
Apr 7, 2023
| @@ -1,2 +1,2 @@ | |||
| /// The hash of the Shorebird engine used by this version of Shorebird CLI. | |||
| const shorebirdEngineRevision = '978a56f2d97f9ce24a2b6bc22c9bbceaaba0343c'; | |||
| const shorebirdEngineRevision = '7aa5c44764e10722d188ece75819f7d10f5269a3'; | |||
There was a problem hiding this comment.
I would expect we'd bump the version of flutter/flutter somewhere instead?
There was a problem hiding this comment.
Ah okay and then we'd get the engine revision from flutter --version?
There was a problem hiding this comment.
I'm not sure what we need the engine revision for anymore? Previously we wanted to make sure Flutter had compatible bits? Now "flutter" is our direct dependency and "engine" is its dependency, and "updater" its, etc. each responsible for validating their own.
eseidel
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change