Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jwt): make authTime optional #227

Merged
merged 2 commits into from
Apr 4, 2023
Merged

fix(jwt): make authTime optional #227

merged 2 commits into from
Apr 4, 2023

Conversation

felangel
Copy link
Contributor

@felangel felangel commented Apr 4, 2023

Description

  • refactor(jwt): make authTime optional

auth_time
Time when the End-User authentication occurred. Its value is a JSON number representing the number of seconds from 1970-01-01T0:0:0Z as measured in UTC until the date/time. When a max_age request is made or when auth_time is requested as an Essential Claim, then this Claim is REQUIRED; otherwise, its inclusion is OPTIONAL. (The auth_time Claim semantically corresponds to the OpenID 2.0 PAPE [OpenID.PAPE] auth_time response parameter.)

https://openid.net/specs/openid-connect-core-1_0.html#IDToken

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the bug Something isn't working label Apr 4, 2023
@felangel felangel requested review from eseidel and bryanoltman April 4, 2023 19:08
@felangel felangel self-assigned this Apr 4, 2023
eseidel
eseidel approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@eseidel eseidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a test?

@felangel felangel merged commit e2b7965 into main Apr 4, 2023
@felangel felangel deleted the refactor/jwt-optional-auth-time branch April 4, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanoltman bryanoltman bryanoltman approved these changes

@eseidel eseidel eseidel approved these changes

Assignees

@felangel felangel

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felangel @eseidel @bryanoltman