feat(shorebird_cli): add --dry-run and --force to shorebird patch
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felangel
changed the title
--dry-run and --force to shorebird patch
eseidel
approved these changes
Mar 31, 2023
| @@ -94,6 +106,14 @@ class PatchCommand extends ShorebirdCommand | |||
| return ExitCode.software.code; | |||
| } | |||
|
|
|||
| final force = results['force'] == true; | |||
There was a problem hiding this comment.
Looks fine, but isn't this also solved by adding default: false to the addFlag?
There was a problem hiding this comment.
Then it's just results['force']? Donno which is clearer. 🤷
There was a problem hiding this comment.
I tried this – results['force'] is still null if no arg is provided.
There was a problem hiding this comment.
default: false is the default but accessing arg flags is dynamic which is why I wrote it this way.
| @@ -433,9 +452,6 @@ Please create a release using "shorebird release" and try again. | |||
|
|
|||
| test('throws error when release artifact cannot be retrieved.', () async { | |||
| const error = 'something went wrong'; | |||
| when( | |||
There was a problem hiding this comment.
Why are these no longer needed?
There was a problem hiding this comment.
They are the default stubs so they were unnecessary
bryanoltman
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change