-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Shorebird engine not available #1209
Comments
I see your project depending on "shorebird_code_push_web directly, I suspect that's wrong and it wants to depend on "shorebird_code_push". I believe "shorebird_code_push" automatically uses one of the other two. And we should probably hide shorebird_code_push_web from depending on directly. FYI @bryanoltman |
Users were sometimes importing the _web version thinking it was the "web safe" import, rather than shorebird_code_push.dart and then being surprised when ShorebirdCodePush did nothing. Fixes shorebirdtech/shorebird#1209
Let me know if that does not resolve your issue! I've moved _web and _io into src/ in shorebirdtech/updater#75 to avoid others importing one of them by mistake. Thanks! |
Hi, this is my case and i did not import "_web" This is my import for
Case 1: When Because this case is automatically updated, checking is not necessary and can be skipped, but I will still report this case to you so you can check further. My problem is in Case 2 when shorebird is available, new patch published but
Detail step: |
Thanks, I will investigate further tomorrow. |
* break: move shorebird_code_push_io and _web into src/ Users were sometimes importing the _web version thinking it was the "web safe" import, rather than shorebird_code_push.dart and then being surprised when ShorebirdCodePush did nothing. Fixes shorebirdtech/shorebird#1209 * Update formating for Dart 3.1
Was unable to reproduce this on Android, trying now on iOS. |
I was not able to reproduce on iOS either. I think this was fixed by shorebirdtech/updater#75. Closing. |
@giapnhgc if you are still having this issue, could you share the logs you're seeing when running |
We would love to help @giapnhgc, please let us know if you're still stuck. We weren't able to reproduce given the information in this bug. https://discord.gg/shorebird can reach us directly as well. |
Unfortunately, on iOS I cannot run the
Because of this, I log print the data and then push it directly through Testflight and create patch to check for updates and logs are returned like my comment above: #1209 (comment) . Or do you have any way to fix it so I can run the command |
Hi @eseidel , @bryanoltman , After I upgrade shorebird to
But we had new issues. Its about |
i got the same issue on android. the project was on flutter 3.10.6 and we upgraded to 3.13.3 just to see if it would work again. the shorebird worked nicely for good time, but now its getting this error. PS F:\Workspace\a toca\tocaapp\atoca_tablet> shorebird preview adb logcat -v --------- beginning of system --------- beginning of main --------- beginning of crash 09-11 21:21:40.044 5378 5439 I flutter : The Dart VM service is listening on http://127.0.0.1:43827/OVGMJhfZyrU=/ 09-11 21:54:33.934 8405 8467 I flutter : The Dart VM service is listening on http://127.0.0.1:43573/hr2_RCwEk-0=/ 09-11 21:54:38.095 8405 8455 I flutter : onCreate(Instance of 'AuthCubit' 09-11 21:55:31.893 8405 8455 I flutter : onCreate(Instance of 'AuthCubit' 09-12 12:05:50.268 9993 10055 I flutter : The Dart VM service is listening on http://127.0.0.1:45433/6w6F0VDuZnM=/ 09-12 12:05:56.219 9993 10043 I flutter : onCreate(Instance of 'AuthCubit' 09-12 12:06:27.361 9993 10043 I flutter : onCreate(Instance of 'StudentWatcherCubit' 09-12 12:11:40.246 10321 10380 I flutter : The Dart VM service is listening on http://127.0.0.1:42841/SSSNOW0430k=/ 09-12 12:11:42.518 10321 10366 I flutter : onCreate(Instance of 'AuthCubit' 09-12 12:11:45.376 10321 10366 I flutter : │ #3 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:5297:15) 09-12 12:53:36.265 10756 10803 I flutter : onCreate(Instance of 'AuthCubit' 09-12 12:53:40.516 10756 10803 I flutter : │ #1 _AuthTabletViewState.build (package:atoca_tablet/presentation/auth/auth_tablet_view.dart:180:35) |
Description
The
shorebird_code_push
library can doesn't detect shorebird even though it is installed and working.Steps To Reproduce
auto_update:false
inshorebird.yaml
shorebird preview
(idk if shorebird allows to preview an app owned by someone else like this)Expected Behavior
shorebird_code_push
detects the shorebird engine and is able to be used normallyScreenshots
If applicable, add screenshots to help explain your problem.
Additional Context
I have tried both with
auto_update:true
andauto_update:false
. In both cases shorebird does what it should but code psuh doesn't detect shorebirdThis is output of
shorebird preview
withauto_update:true
:And this is output of
shorebird preview
withauto_update:false
:The text was updated successfully, but these errors were encountered: