Skip to content

Commit

Permalink
lints
Browse files Browse the repository at this point in the history
  • Loading branch information
bryanoltman committed Jan 3, 2025
1 parent 68f7d84 commit c13b7e6
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
5 changes: 2 additions & 3 deletions packages/shorebird_cli/lib/src/artifact_builder.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import 'package:shorebird_cli/src/shorebird_artifacts.dart';
import 'package:shorebird_cli/src/shorebird_documentation.dart';
import 'package:shorebird_cli/src/shorebird_env.dart';
import 'package:shorebird_cli/src/shorebird_process.dart';
import 'package:stream_transform/stream_transform.dart';

/// Used to wrap code that invokes `flutter build` with Shorebird's fork of
/// Flutter.
Expand Down Expand Up @@ -579,7 +578,7 @@ Either run `flutter pub get` manually, or follow the steps in ${cannotRunInVSCod
.transform(const LineSplitter())
.listen((line) {
logger.detail(line);
// TODO: update build progress
// TODO(bryanoltman): update build progress
});

final stderrLines = await buildProcess.stderr
Expand All @@ -594,7 +593,7 @@ Either run `flutter pub get` manually, or follow the steps in ${cannotRunInVSCod
});

final projectRoot = shorebirdEnv.getShorebirdProjectRoot()!;
// TODO: extract this to function, ensure this is correct
// TODO(bryanoltman): extract this to function, ensure this is correct
return Directory(
p.join(
projectRoot.path,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,17 @@ class WindowsPatcher extends Patcher {
});

@override
// TODO: exe isn't technically correct - we upload a zip containing the exe
// along with dlls and assets. We should find a better name for this.
// TODO(bryanoltman): exe isn't technically correct - we upload a zip
// containing the exe along with dlls and assets. We should find a better name
// for this.
String get primaryReleaseArtifactArch => 'exe';

@override
ReleaseType get releaseType => ReleaseType.windows;

@override
Future<void> assertPreconditions() async {
// TODO: implement assertPreconditions
// TODO(bryanoltman): implement assertPreconditions
}

@override
Expand All @@ -47,7 +48,7 @@ class WindowsPatcher extends Patcher {
required File releaseArchive,
required File patchArchive,
}) async {
// TODO: implement assertUnpatchableDiffs
// TODO(bryanoltman): implement assertUnpatchableDiffs
return const DiffStatus(hasAssetChanges: false, hasNativeChanges: false);
}

Expand Down Expand Up @@ -87,7 +88,7 @@ class WindowsPatcher extends Patcher {
'windows',
'x64',
'runner',
// TODO: does this change with flavors?
// TODO(bryanoltman): does this change with flavors?
// from android:
// flavor != null ? '${flavor}Release' : 'release',
'Release',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:path/path.dart' as p;
import 'package:scoped_deps/scoped_deps.dart';
import 'package:shorebird_cli/src/executables/git.dart';
import 'package:shorebird_cli/src/shorebird_env.dart';
import 'package:shorebird_cli/src/validators/tracked_lock_files_validator.dart';
import 'package:shorebird_cli/src/validators/validators.dart';
import 'package:test/test.dart';

Expand Down

0 comments on commit c13b7e6

Please sign in to comment.