Windows build

[bryanoltman]

Ready for review, with the caveat that there will be cleanup done as a followup PR to consolidate how/when ConfigureShorebird is called, with the eventual goal being a single ConfigureShorebird function.

Notes doc: https://docs.google.com/document/d/18t791EDSN03FbuZM9uE50CE36ZppF5i8PDaO7l6Bcms/edit?tab=t.0

Rust Setup

In engine/src/third_party/updater, run:

rustup target add x86_64-pc-windows-msvc
cargo build --release --target x86_64-pc-windows-msvc

Flutter Build

./flutter/tools/gn --runtime-mode release --no-rbe --no-lto
ninja -C .\out\host_release flutter/build/archives:windows_flutter

These commands were adapted from ci\builders\windows_host_engine.json

Other notes

The ninja build sometimes gets stuck in the following loop and I don't know why:

PS C:\Users\bryan\shorebirdtech\engine\src> ninja -C .\out\host_release flutter/build/archives:windows_flutter
ninja: Entering directory `.\out\host_release'
[0/1] Regenerating ninja files//out/host_release/environment.x64
HOMEDRIVE=C:
[0/1] Regenerating ninja files//out/host_release/environment.x64
HOMEDRIVE=C:
[0/1] Regenerating ninja files//out/host_release/environment.x64
HOMEDRIVE=C:
[0/1] Regenerating ninja files

[eseidel]

You can just call .get() to get the pointer out of unique_ptr. https://en.cppreference.com/w/cpp/memory/unique_ptr

…

On Fri, Jan 3, 2025 at 2:03 PM Bryan Oltman ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In shell/platform/windows/flutter_windows_engine.cc <#94 (comment)>: > + std::vector<char> version_data(version_info_size); + if (!GetFileVersionInfoA(module_path, handle, version_info_size, + version_data.data())) { + return -1; This is used for a function that expects an LPVOID (void *) later on, and it doesn't look like unique_ptr plays nicely with that — Reply to this email directly, view it on GitHub <#94 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADU2TPUCMXZ4HVXS3LE7BT2I4CKBAVCNFSM6AAAAABTZL5SSOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMRZG43TGOJRHA> . You are receiving this because you commented.Message ID: ***@***.***>