Skip to content

Commit

Permalink
Support x64 Android
Browse files Browse the repository at this point in the history
Also updated paths to depend on updater.h and libupdater.a
from third_party directly now that DEPS knows how to pull
down updater for us.

We still don't build updater from gn/ninja yet (we should)
but this at least fixes the ninja null build to be null again
previously it was rebuilding common.shell.o every time,
unclear why.
  • Loading branch information
eseidel authored and felangel committed Jun 8, 2023
1 parent 4490340 commit fb482b1
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 4 deletions.
2 changes: 1 addition & 1 deletion shell/common/shell.cc
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
#include "third_party/skia/include/utils/SkBase64.h"
#include "third_party/tonic/common/log.h"

#include "updater.h"
#include "third_party/updater/library/include/updater.h"

namespace flutter {

Expand Down
16 changes: 14 additions & 2 deletions shell/platform/android/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -142,9 +142,21 @@ source_set("flutter_shell_native_src") {
"GLESv2",
]
if (target_cpu == "arm") {
libs += [ "//flutter/updater/android_arm/libupdater.a" ]
libs += [ "//third_party/updater/target/armv7-linux-androideabi/release/libupdater.a" ]
} else if (target_cpu == "arm64") {
libs += [ "//flutter/updater/android_aarch64/libupdater.a" ]
libs += [
"//third_party/updater/target/aarch64-linux-android/release/libupdater.a",
]
} else if (target_cpu == "x64") {
libs += [
"//third_party/updater/target/x86_64-linux-android/release/libupdater.a",
]
} else if (target_cpu == "x86") {
libs += [
"//third_party/updater/target/i686-linux-android/release/libupdater.a",
]
} else {
assert(false, "Unsupported target_cpu")
}
}

Expand Down
2 changes: 1 addition & 1 deletion shell/platform/android/flutter_main.cc
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
#include "third_party/dart/runtime/include/dart_tools_api.h"
#include "third_party/skia/include/core/SkFontMgr.h"

#include "updater.h"
#include "third_party/updater/library/include/updater.h"

namespace flutter {

Expand Down

0 comments on commit fb482b1

Please sign in to comment.