Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed getBaseQuery select to call the correct absolute path (not relative) #145

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

ray-magini
Copy link
Contributor

As per my understanding this needs to be an absolute path in this case to make it callable.

Fixed getBaseQuery select to call the correct absolute path (not relative)
@mitelg
Copy link
Contributor

mitelg commented Nov 14, 2018

hey @ray-magini
thanks for your PR. currently the creation of a plugin seems to be broken. which command do you use, to create a plugin?
my files are named like this: 'plugin:create' SwagTest -m -a.php and the class declaration looks like this class 'plugin:create' SwagTest -m -a extends ModelEntity
do you have the same problem?

@ray-magini
Copy link
Contributor Author

hi @mitelg
I use the command /opt/remi/php70/root/bin/php bin/sw plugin:create --haveBackend --backendModel=RmTestModel --haveApi RmTest

First to ensure that i use php 7.0, execute bin/sw from the sw-cli-tools folder and create the plugin with backend, model and api

@larsbo
Copy link

larsbo commented Nov 14, 2018

@mitelg I created an issue for plugin creation bug a while ago: #108 😉

@mitelg mitelg merged commit 8712979 into shopwareLabs:master Nov 14, 2018
@mitelg
Copy link
Contributor

mitelg commented Nov 14, 2018

thanks for your PR @ray-magini 👍 💙

@larsbo I will have a look 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants