PPI-1056 - Refactor payment handlers to AbstractPaymentHandlers #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstegmeyer
force-pushed
the
ppi-1056/refactor-to-abstractpaymenthandlers
branch
2 times, most recently
from
fc2a1a9 to
752a6c4
Compare
mstegmeyer
force-pushed
the
ppi-1056/refactor-to-abstractpaymenthandlers
branch
10 times, most recently
from
8305258 to
8880f44
Compare
mstegmeyer
force-pushed
the
ppi-1056/refactor-to-abstractpaymenthandlers
branch
from
8880f44 to
b7df3cf
Compare
cyl3x
reviewed
Feb 13, 2025
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| #[Package('checkout')] | ||
| class CheckoutException extends PaymentException |
There was a problem hiding this comment.
Maybe we should merge all our PaymentException extensions
| } | ||
|
|
||
| public function checkForCustomerData(OrderEntity $order, DataBag $dataBag, SalesChannelContext $salesChannelContext): void | ||
| public function checkForCustomerData(PaymentTransactionStruct $transaction, Request $request, Context $context): void |
There was a problem hiding this comment.
Can't we still just rely on the DataBag? relying on the request in a service seems unfortunate
Comment on lines
+144
to
+146
| if (!$this->attemptExecution()) { | ||
| return $paypalOrder; | ||
| } |
There was a problem hiding this comment.
can't we override this function and add the early return instead?
| return null; | ||
| } | ||
|
|
||
| protected function executeOrder(PaymentTransactionStruct $transaction, Order $paypalOrder, OrderEntity $order, OrderTransactionEntity $orderTransaction, Context $context, bool $isUserPresent = true): Order |
There was a problem hiding this comment.
protected functions should go after public
There was a problem hiding this comment.
that should be a case for the CS fixer 🙂
There was a problem hiding this comment.
Yes, it seems we missed the rule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining issues / to check: