Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPI-1030 - Revamp administration #49

Merged
merged 14 commits into from
Jan 29, 2025
Merged

PPI-1030 - Revamp administration #49

merged 14 commits into from
Jan 29, 2025

Conversation

cyl3x
Copy link
Contributor

@cyl3x cyl3x commented Dec 2, 2024

Hint to review this

It makes sense to look this through commit by commit, no file is touched twice (except index files / import statements)


Goals:

  • Reduce complexity and components
  • Increase readability
  • Simplify by abstract common behaviour - even label & helpText snippets
  • No longer override SystemConfigController - but still register webhook and show errors about it
  • validate-api-credentials shouldn't throw errors, as 401 will trigger a retry-request

The idea:

  • Separate settings and payment method card
  • Create shared states for system-config (swagPayPalSettings store) and merchant-information (swagPayPalMerchantInformation store)
  • Onboarding is a component and reduced to a button
  • settings tabs are actual routes with own views
  • swag-paypal-settings-wrapper creates common fields like switch, single-select and text-field (but nothing specific for a setting)
  • SettingsSaver will save system settings and reregisteres the webhook + check if changed credentials are valid
  • SettingsController will use the SettingsSaver for an own system-config save route

For later:

  • We can show the validity of the given credentials after saving, as the settings save route provides us with this information

To check:

  • Where to place blocks, as we should place them more carefully

@cyl3x cyl3x added Feature Request Work in progress Proposal is work in progress labels Dec 2, 2024
@cyl3x cyl3x force-pushed the poc/new-settings-page branch 6 times, most recently from c6a4aff to 6a4aff1 Compare December 9, 2024 19:41
@cyl3x cyl3x changed the title POC - Settings tweaks PPI-1030 - Revamp administration Dec 9, 2024
@cyl3x cyl3x force-pushed the poc/new-settings-page branch from 6a4aff1 to 63e835d Compare December 9, 2024 20:11
@cyl3x cyl3x marked this pull request as draft December 9, 2024 20:12
@cyl3x cyl3x force-pushed the poc/new-settings-page branch 2 times, most recently from f4caf94 to 237c9f8 Compare December 10, 2024 20:08
@cyl3x cyl3x force-pushed the poc/new-settings-page branch 3 times, most recently from 5df511b to 40676c4 Compare December 13, 2024 17:03
@cyl3x cyl3x force-pushed the poc/new-settings-page branch 3 times, most recently from 3a968c2 to 7f14ad9 Compare December 20, 2024 19:32
@cyl3x cyl3x force-pushed the poc/new-settings-page branch 7 times, most recently from 0db8509 to 595a83b Compare January 15, 2025 10:22
@cyl3x cyl3x requested a review from Bird87ZA January 15, 2025 10:37
@cyl3x cyl3x marked this pull request as ready for review January 15, 2025 10:37
@cyl3x cyl3x added Status:In-Review Work on this issue is complete and is now pending review. and removed Work in progress Proposal is work in progress labels Jan 15, 2025
@cyl3x cyl3x force-pushed the poc/new-settings-page branch from 595a83b to f56fbe2 Compare January 15, 2025 14:38
@cyl3x cyl3x force-pushed the poc/new-settings-page branch from f56fbe2 to 02cbe23 Compare January 15, 2025 14:54
@cyl3x cyl3x requested a review from mstegmeyer January 16, 2025 07:46
@cyl3x cyl3x self-assigned this Jan 16, 2025
mstegmeyer
mstegmeyer previously approved these changes Jan 24, 2025
Bird87ZA
Bird87ZA previously approved these changes Jan 27, 2025
@cyl3x cyl3x dismissed stale reviews from Bird87ZA and mstegmeyer via a2bcd86 January 27, 2025 12:22
@cyl3x cyl3x force-pushed the poc/new-settings-page branch from a2bcd86 to e8c743a Compare January 27, 2025 12:24
@cyl3x cyl3x requested a review from Bird87ZA January 29, 2025 07:55
@cyl3x cyl3x merged commit d145bcc into trunk Jan 29, 2025
22 checks passed
@cyl3x cyl3x deleted the poc/new-settings-page branch January 29, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Status:In-Review Work on this issue is complete and is now pending review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants