-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPI-1030 - Revamp administration #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyl3x
force-pushed
the
poc/new-settings-page
branch
6 times, most recently
from
December 9, 2024 19:41
c6a4aff
to
6a4aff1
Compare
cyl3x
force-pushed
the
poc/new-settings-page
branch
from
December 9, 2024 20:11
6a4aff1
to
63e835d
Compare
cyl3x
force-pushed
the
poc/new-settings-page
branch
2 times, most recently
from
December 10, 2024 20:08
f4caf94
to
237c9f8
Compare
mstegmeyer
reviewed
Dec 11, 2024
mstegmeyer
requested changes
Dec 11, 2024
src/Resources/app/administration/src/app/component/swag-paypal-setting/index.ts
Outdated
Show resolved
Hide resolved
...p/administration/src/module/swag-paypal-method/component/swag-paypal-payment-method/index.ts
Outdated
Show resolved
Hide resolved
cyl3x
force-pushed
the
poc/new-settings-page
branch
3 times, most recently
from
December 13, 2024 17:03
5df511b
to
40676c4
Compare
cyl3x
force-pushed
the
poc/new-settings-page
branch
3 times, most recently
from
December 20, 2024 19:32
3a968c2
to
7f14ad9
Compare
cyl3x
force-pushed
the
poc/new-settings-page
branch
7 times, most recently
from
January 15, 2025 10:22
0db8509
to
595a83b
Compare
cyl3x
added
Status:In-Review
Work on this issue is complete and is now pending review.
and removed
Work in progress
Proposal is work in progress
labels
Jan 15, 2025
cyl3x
force-pushed
the
poc/new-settings-page
branch
from
January 15, 2025 14:38
595a83b
to
f56fbe2
Compare
cyl3x
force-pushed
the
poc/new-settings-page
branch
from
January 15, 2025 14:54
f56fbe2
to
02cbe23
Compare
mstegmeyer
previously approved these changes
Jan 24, 2025
Bird87ZA
previously approved these changes
Jan 27, 2025
cyl3x
force-pushed
the
poc/new-settings-page
branch
from
January 27, 2025 12:24
a2bcd86
to
e8c743a
Compare
Bird87ZA
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hint to review this
It makes sense to look this through commit by commit, no file is touched twice (except index files / import statements)
Goals:
SystemConfigController
- but still register webhook and show errors about itThe idea:
swagPayPalSettings
store) and merchant-information (swagPayPalMerchantInformation
store)swag-paypal-settings-wrapper
creates common fields like switch, single-select and text-field (but nothing specific for a setting)SettingsSaver
will save system settings and reregisteres the webhook + check if changed credentials are validSettingsController
will use the SettingsSaver for an own system-config save routeFor later:
To check: