Enforce Linter #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when receiving apps are initialized in development
sypher7
previously requested changes
Mar 5, 2018
lib/bd_lint/validator.rb
Outdated
| class GitHookError < StandardError; end | ||
|
|
||
| def self.check | ||
| raise GitHookError, "Please run `bundle exec rake bd_lint:generate:pre_commit`" if invalid? |
There was a problem hiding this comment.
It looks like this task isn't defined for rails projects -- that logic might be backwards in the task definitions?
If that is how it is supposed to work, we should reflect that logic here.
adayag
approved these changes
Mar 6, 2018
kmazanec
approved these changes
Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a better guiding hand in setting up development environments with BD Lint. It will raise an error and prevent the app from booting in development and tests until the developer has run the necessary commands to tie in the required git hooks.
@shopsmart/web-team