This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Handle workspace modifications #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
commented
Jul 20, 2022
| @@ -21,6 +21,8 @@ def path(relative_path) | |||
|
|
|||
| def read(relative_path) | |||
| file(relative_path).read(mode: 'rb', encoding: 'UTF-8') | |||
| rescue Errno::ENOENT | |||
| nil | |||
There was a problem hiding this comment.
Logic here is that InMemoryStorage also returns string | nil, so we're copying the signature by catching those errors.
charlespwd
commented
Jul 20, 2022
charlespwd
commented
Jul 20, 2022
charlespwd
force-pushed
the
fix/588-handle-file-deletion
branch
from
97654ca to
0463fc9
Compare
charlespwd
force-pushed
the
fix/588-handle-file-deletion
branch
from
0463fc9 to
74ce506
Compare
* Minor refactor of DiagnosticsEngine * Handle array argument in analyze_and_send_offenses * Adjust file rename diagnostics handling - update our storage - clear the old diagnostics from the DiagnosticsManager - send "NO_DIAGNOSTICS" to the client for the deleted files - rerun theme check for the new files * More diagnostic lifecycle fixes - When you close a file and only_single_file is on, clear its diagnostics - If you delete or rename a file, clear its diagnostics and rerun whole theme checks (in case MissingTemplate should now be reported) Fixes #569
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #588
Issue summary:
textDocument/didClosehandler to throw anErrno::ENOENTwhen trying to "sync" the storage with the file system.Fix summary:
Errno::ENOENTintextDocument/didClosefor language clients that do not support theworkspace.fileOperations.didDeleteFilesclient capabilityworkspace/didCreateFilesworkspace/didDeleteFilesworkspace/willRenameFilesnew path in the InMemoryStorage, and then remove the content at the
old path.