Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Theme check crashes when file is deleted #588

Closed
vfonic opened this issue Jun 7, 2022 · 1 comment · Fixed by #611
Closed

Theme check crashes when file is deleted #588

vfonic opened this issue Jun 7, 2022 · 1 comment · Fixed by #611
Assignees
Labels
bug Something isn't working language server Language Server related issues

Comments

@vfonic
Copy link

vfonic commented Jun 7, 2022

This happens a lot, especially when switching git branches and is a bit distracting when working.

I think theme check shouldn't crash in such cases.

@vfonic
Copy link
Author

vfonic commented Jun 7, 2022

This could be VS Code extension issue so please move it there.

@charlespwd charlespwd added bug Something isn't working language server Language Server related issues labels Jul 11, 2022
@charlespwd charlespwd self-assigned this Jul 13, 2022
charlespwd added a commit that referenced this issue Jul 20, 2022
charlespwd added a commit that referenced this issue Jul 20, 2022
charlespwd added a commit that referenced this issue Jul 20, 2022
charlespwd added a commit that referenced this issue Jul 28, 2022
charlespwd added a commit that referenced this issue Jul 28, 2022
* Handle workspace modifications

Fix #588

* fix/569 full theme check removed files (#621)

* Minor refactor of DiagnosticsEngine

* Handle array argument in analyze_and_send_offenses

* Adjust file rename diagnostics handling

- update our storage
- clear the old diagnostics from the DiagnosticsManager
- send "NO_DIAGNOSTICS" to the client for the deleted files
- rerun theme check for the new files

* More diagnostic lifecycle fixes

- When you close a file and only_single_file is on, clear its diagnostics
- If you delete or rename a file, clear its diagnostics and rerun whole theme
  checks (in case MissingTemplate should now be reported)

Fixes #569
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working language server Language Server related issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants