This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Fix unknown configuration issue for UndefinedObject checker #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veken1199
force-pushed
the
fix-theme-app-extension-config
branch
from
f10aa51 to
88cc328
Compare
charlespwd
approved these changes
Mar 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #566
We introduced a new arg for UndefinedObject checker without providing a default value for this arg/configuration in
default.yml. This cause theme-check to report warning:unknown configuration: UndefinedObject.config_typeWe added this configuration in
default.ymlconfig file and fixed the values of these configs to a propersymbolformat in the yml file