This repository has been archived by the owner on Jul 27, 2024. It is now read-only.
Support app drop in theme app extensions #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catlee
approved these changes
Mar 25, 2022
|
Hi, Could someone respond to this: https://community.shopify.com/c/online-store-2-0/accessing-app-owned-metafields-from-theme-extension-block-liquid/m-p/1879073 ? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We would like to support
AppLiquid drop in theme app extension Liquid code such as app blocks and embeds.How did we implement this change?
We updated the initializer of
UndefinedObjectchecker to take a new arg calledconfig_typewhich is set to:defaultas the default value. We updated then theme app extension config file to pass theconfig_typeofUndefinedObjectchecker as:theme_app_extension. Base on theconfig_type` we will be able to allow and reject more liquid objects in theme app extension liquid code.