Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

Fixup windows executable duplication #400

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Aug 26, 2021

Turns out that the Gemspec's executables option makes the .bat files for us.

I've tested this works properly on windows by doing the following:

  1. Deleting the files and committing the delete
  2. gem build theme-check.gemspec
  3. gem install --bindir bin2 --local theme-check
  4. dir bin2, making sure that there aren't 2 .bat.bat files and that the .bat files work properly.

Fixes #371

Turns out that the Gemspec's executables option makes the .bat files for us.

Fixes #371
@charlespwd charlespwd force-pushed the fix/371-windows-bat-wtf branch from f7dc6d1 to 8b57146 Compare August 26, 2021 14:45
@charlespwd charlespwd requested a review from macournoyer August 26, 2021 14:55
Copy link
Contributor

@macournoyer macournoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I don't understand why you tophated w/ gem install --bindir bin2 --local theme-check. Will this behave the same as when ppl install w/o args?

@charlespwd
Copy link
Contributor Author

charlespwd commented Aug 26, 2021

I wanted to see the executables. Easier to see em with the --bindir. Otherwise they get installed in the default gem's bindir which is a lot harder to get to on Windows since I'm not a cmd.exe wizard.

And yes! That's the way to install local gems instead of remote gems. You build it first and then install it from the file that the build created.

I used the --bindir flag so that it was easier to see what happened in the bin folder. Wanted to make sure no duplicate .bat.bat files were created.

@charlespwd charlespwd merged commit bdf5b94 into main Aug 26, 2021
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems August 30, 2021 14:10 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

theme-check error while executing on Windows 10
2 participants