Skip to content
This repository has been archived by the owner on Jul 27, 2024. It is now read-only.

theme-check error while executing on Windows 10 #371

Closed
m-atek opened this issue Jul 16, 2021 · 2 comments · Fixed by #400
Closed

theme-check error while executing on Windows 10 #371

m-atek opened this issue Jul 16, 2021 · 2 comments · Fixed by #400
Labels
bug Something isn't working e:2 Effort: 2 p:high Priority (or Impact): High

Comments

@m-atek
Copy link

m-atek commented Jul 16, 2021

Hi, I have an issue running theme-check on Windows 10. I get multiple lines like this one:

#!C:/Ruby30-x64/bin/ruby.exe '#!C:' is not recognized as an internal or external command, operable program or batch file.

I have C:/Ruby30-x64/bin directory in my PATH. I could not find solution online.

Thanks in advance.
@charlespwd charlespwd added the bug Something isn't working label Aug 10, 2021
@charlespwd charlespwd added e:2 Effort: 2 p:high Priority (or Impact): High labels Aug 10, 2021
@ADTC
Copy link

ADTC commented Aug 16, 2021 •
edited
Loading

For some reason, the .bat files are copies of the shell scripts, and then there are .bat.bat files which are the actual batch files.

image

If you want to fix this in your local installation, delete the bad .bat files and rename the good .bat.bat files to .bat:

image

@charlespwd
Copy link
Contributor

For some reason, the .bat files are copies of the shell scripts, and then there are .bat.bat files which are the actual batch files.

image

I'll have to look into this. Looks like our gemspec is doing funky stuff.

@ADTC ADTC mentioned this issue Aug 17, 2021
Closed
@ADTC ADTC mentioned this issue Aug 26, 2021
Closed
charlespwd added a commit that referenced this issue Aug 26, 2021
@charlespwd
Remove the .bat files and fix windows.
f7dc6d1 
Turns out that the Gemspec's executables option makes the .bat files for us.

Fixes #371
charlespwd added a commit that referenced this issue Aug 26, 2021
@charlespwd
Remove the .bat files and fix windows.
8b57146 
Turns out that the Gemspec's executables option makes the .bat files for us.

Fixes #371
@charlespwd charlespwd mentioned this issue Aug 26, 2021
Merged
hannakebedom pushed a commit that referenced this issue Aug 30, 2021
@charlespwd @hannakebedom
Remove the .bat files and fix windows.
299df13 
Turns out that the Gemspec's executables option makes the .bat files for us.

Fixes #371
@charlespwd charlespwd mentioned this issue Aug 30, 2021
Closed
@charlespwd charlespwd mentioned this issue Sep 16, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working e:2 Effort: 2 p:high Priority (or Impact): High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixup windows executable duplication Shopify/theme-check
3 participants
@charlespwd @ADTC @m-atek