feat: Support slog Logger

[raed-shomali]

This should take care of #148

[arusso]

I think the error in staticcheck is because we're specifying Go 1.18 as the minimum version, but slog isn't available until 1.21. Combined with the new changes in how that file are read in Go 1.21 necessitate updating go.mod to 1.21:

To improve forwards compatibility, Go 1.21 now reads the go line in a go.work or go.mod file as a strict minimum requirement: go 1.21.0 means that the workspace or module cannot be used with Go 1.20 or with Go 1.21rc1.

[raed-shomali]

But go.mod has been updated to Go 1.21 as seen in the PR. What am I missing?

[arusso]

I think the usage of logging functions needs correcting, though I question if we're doing the right thing. The whole point of structured logging is to provided logs in a structured format, and I think we're still trying to use it as an unstructured logger which doesn't make much sense.

[arusso]

But go.mod has been updated to Go 1.21 as seen in the PR. What am I missing?

Oh so it is, let me look at the action a bit more and see why it's not liking that then.

[raed-shomali]

As for your comment on the logging, I am not really doing anything special other than pass the arguments to the slog logger.

The default slog logger is setup with a JSON handler but you can change that behavior.

Here are some examples when I was testing:

slacker % go run examples/interaction-middleware/main.go 
{"time":"2023-10-30T22:56:51.22708-04:00","level":"INFO","msg":"connecting to Slack with Socket Mode..."}
2023/10/30 22:56:51 not_authed

And here's some nonsense tests with a Text Handler:

slacker % go run examples/logger/main.go                
time=2023-10-30T22:57:28.498-04:00 level=INFO msg=meow
time=2023-10-30T22:57:28.499-04:00 level=ERROR msg=meow
time=2023-10-30T22:57:28.499-04:00 level=WARN msg=meow
time=2023-10-30T22:57:28.499-04:00 level=INFO msg="connecting to Slack with Socket Mode..."

[arusso]

Try rebasing on master and re-pushing, hopefully that takes care of the staticcheck errors.

[arusso]

As for your comment on the logging, I am not really doing anything special other than pass the arguments to the slog logger.

My point is that this change doesn't take full advantage of slog, and I think if we're going to support it we should lean into it more. Take for instance the Writer.Delete(), we should embed useful information here so the user does less work ingesting this log data. Something like:

r.logger.Error("failed to delete message", "error", err,  "channel", channel, "message_timestamp", messageTimetamp)
# 2023/11/06 18:22:03 ERROR failed to delete message error="whoops, my bad" channel=CHANNELID message_timestamp=123456...

Of course, this means we're committing to slog since the log module (or anything like it) wont output that properly. If we want to support both, we'll need to do some extra logic to ensure we're properly formatting logs regardless of whether they're expected to be structured or not.

[raed-shomali]

Ah! Now I understand your point. Thanks. Will clean up.

[raed-shomali]

How do you like the changes now?

[arusso]

Moved to github.com/slack-io/slacker