Validate audio channel map before applying #1379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Feature: Add audio channel map validation
Here's a case I'm trying to solve:
There are other situations like this, for instance, just setting
stream.audioSettings.channelMap = [3]
.The problem here is that audio input and output formats are not exposed outside of the library and
channelMap
cannot be corrected before it's applied to the converter.Theoretically, both formats or the converted itself could be exposed, but it has some downsides. For example, need to add extra delegate methods to IOAudioResamplerDelegate -> IOAudioUnitDelegate -> IOMixerDelegate -> IOStreamDelegate. So I choose an option to automatically validate the current channelMap to make sure that:
Type of change
Please delete options that are not relevant.
Screenshots: