Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore AudioEffect feature #1306

Closed

Conversation

levs42
Copy link
Contributor

@levs42 levs42 commented Sep 28, 2023

Description & motivation

Bringing AudioEffect back as it's very useful for exposing audio buffer from the library for an external use.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Screenshots:

@shogo4405
Copy link
Owner

I have removed it since it can be obtained through this delegate method. Since it shares the same interface as AudioEffect, I think it can be a suitable alternative.
https://github.com/shogo4405/HaishinKit.swift/blob/main/Sources/Net/NetStream.swift#L14

@levs42
Copy link
Contributor Author

levs42 commented Sep 28, 2023

Cool, I didn't see that method! Thank you for pointing to the right direction.

@levs42 levs42 closed this Sep 28, 2023
@levs42 levs42 deleted the feature/restore-audio-effects branch November 6, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants