Support downmix feature and refactor. #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shogo4405
force-pushed
the
feature/mono-to-stereo
branch
from
558ceda to
a6725f4
Compare
levs42
reviewed
Sep 28, 2023
| } | ||
|
|
||
| func invalidate(_ oldValue: IOAudioResamplerSettings!) -> Bool { | ||
| return (sampleRate != oldValue.sampleRate && |
There was a problem hiding this comment.
Does this need to have OR condition? Please take look, thanks.
shogo4405
added a commit
that referenced
this pull request
Sep 29, 2023
shogo4405
added a commit
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Type of change
Please delete options that are not relevant.
Screenshots: