I love the smell of Rubocop fixes in the morning. #1118
Conversation
| width ||= @style[:diameter] || @style[:width] || (@style[:radius] || 0) * 2 | ||
| left ||= @style[:left] | ||
| top ||= @style[:top] | ||
| width ||= @style[:diameter] || @style[:width] || (@style[:radius] || 0) * 2 |
There was a problem hiding this comment.
hm, I do disagree with this - might be my personal style (and that my IDE makes those for me) but I like lining op = operators just as I like lining up => in hashes, tremendously improves readability imo :)
There was a problem hiding this comment.
Thanks for pointing this out, I missed this and I agree with you. Looks like there's a configuration option called MultiSpaceAllowedForOperators that will allow lining these up. I'll drop this commit from the PR and make a new one for this cop.
|
Most of this looks good 👍 Personally I like aligning operators such as The other things are about spaces around braces, where I'm not entirely sure. Tobi |
|
Added some notes above, I'll move the questionable commits into their own PRs |
jaredmoody
force-pushed
the
rubocop
branch
3 times, most recently
from
19a31fd to
45290ed
Compare
|
Rebased against master and bumped some method length/complexity limits from new code in master :P |
|
Rebased against master after |
| @@ -79,16 +79,16 @@ def run(str) | |||
| when "\n" | |||
| begin | |||
| out, obj = IRBalike.run(@cmd + ';') | |||
| @str += ["#@cmd\n", | |||
| @str += ["#{@cmd}\n", | |||
There was a problem hiding this comment.
Didn't even realize this was allowed with strings! Glad to see it going away 😁
|
Reading through this, I'm happy with the hash changes as they stand so I'll take it. |
Low hanging fruit - style autocorrect fixes for #945