update for env var's

shobhamrj · May 21, 2023 · 56b77b2 · 56b77b2
1 parent be5eae1
commit 56b77b2
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -21,4 +21,4 @@ Architecture Choice and Reasoning:
 
 4. MongoDB: MongoDB is chosen as the database for storing URL data. MongoDB is a popular NoSQL database that offers flexibility and scalability, making it suitable for handling large amounts of data. It allows for easy storage and retrieval of JSON-like documents, which aligns well with the nature of the data being stored in the URL hashing service. Additionally, MongoDB's schema-less design enables agile development.
 
-Overall, this architecture choice combines the flexibility of Node.js and Express.js, the scalability and ease of deployment offered by the serverless framework and AWS services, and the efficient data storage provided by MongoDB. It aims to create a high-performance, scalable, and reliable URL shortening service that can handle a large number of requests while minimizing operational complexity.
+Overall, this architecture choice combines the flexibility of Node.js and Express.js, the scalability and ease of deployment offered by the serverless framework and AWS services, and the efficient data storage provided by MongoDB. It aims to create a high-performance, scalable, and reliable URL hashing service that can handle a large number of requests while minimizing operational complexity.
diff --git a/serverless.yml b/serverless.yml
@@ -8,9 +8,11 @@ provider:
   name: aws
   runtime: nodejs18.x
   region: ap-south-1
+  environment:
+    MONGO_URI: ${file(./secret.json):MONGO_URI}
 
 functions:
   api:
     handler: index.handler
     events:
-      - httpApi: '*'
+      - httpApi: '*'
diff --git a/swagger.yaml b/swagger.yaml
@@ -52,10 +52,6 @@ paths:
           description: Found
         '400':
           description: Bad Request
-          content:
-            text/plain:
-              schema:
-                type: string
         '500':
           description: Internal Server Error
       tags:
Original file line number	Diff line number	Diff line change
Expand Up		@@ -21,4 +21,4 @@ Architecture Choice and Reasoning:

		4. MongoDB: MongoDB is chosen as the database for storing URL data. MongoDB is a popular NoSQL database that offers flexibility and scalability, making it suitable for handling large amounts of data. It allows for easy storage and retrieval of JSON-like documents, which aligns well with the nature of the data being stored in the URL hashing service. Additionally, MongoDB's schema-less design enables agile development.

		Overall, this architecture choice combines the flexibility of Node.js and Express.js, the scalability and ease of deployment offered by the serverless framework and AWS services, and the efficient data storage provided by MongoDB. It aims to create a high-performance, scalable, and reliable URL shortening service that can handle a large number of requests while minimizing operational complexity.
		Overall, this architecture choice combines the flexibility of Node.js and Express.js, the scalability and ease of deployment offered by the serverless framework and AWS services, and the efficient data storage provided by MongoDB. It aims to create a high-performance, scalable, and reliable URL hashing service that can handle a large number of requests while minimizing operational complexity.