First pass of new iteration, see #7 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiryz
requested changes
Oct 28, 2018
README.md
Outdated
| ``` | ||
| Here we can see `theCallBack` passed to foo as an argument and as expected this will log `Jack, come back`. | ||
| Here we can see `theCallBack` passed to `run` as an argument and as expected this will log `Jack, come back`. Remember that this WONT WORK: |
There was a problem hiding this comment.
The won't work note looks incomplete
😅 The analogy of some kind of cooking or serving is a good one, but I think it works better spoken, rather than written (especially for people who aren't so confident with their English). I was trying to strip away as much as possible from the explanations. The mentors can handle the detail. Which reminds me, we should probably add mentor notes to this after it's given in the WB for the first time. @m4v15 do you have any comments? |
shiryz
approved these changes
Oct 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments welcome!
The diff is probably not useful to look at, checkout the rendered view.