fix host.Info() panic if /etc/debian_version is empty #822
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReadLines
helper function doesn't guarantee that the length of lines is non-zero or that the lines have contents. Most callers include a check for length but this was missing for version fingerprinting on Debian if/etc/debian_version
was empty, leading to a panic.This contributed to a panic for a user of Nomad in hashicorp/nomad#6954. A minimal reproduction using a Debian Buster container is below.
To fix, I've reused the same length check done everywhere else in the
host_linux.go
file, and extended the zero-check for the Alpine version fingerprinting to match as well.Reproduction:
main.go
:Before fix:
After fix: