[process] Fix #607 properly check PID existence #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s+GetExitCodeProcess Reference https://stackoverflow.com/a/600217
Lomanic
changed the title
Lomanic
changed the title
5 tasks
|
This is really great PR! thank you so much! |
i-prudnikov
reviewed
Jan 14, 2020
| if err != nil { | ||
| return false, err | ||
| } | ||
| err = proc.Signal(syscall.Signal(0)) |
There was a problem hiding this comment.
This line actually breaks the whole story if you are running inside container, and you are tracking host processes.
More details can be found here:
influxdata/telegraf#6813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #607
Use signal(0) on posix-compliant platforms (linux freebsd openbsd darwin)
Use OpenProcess+GetExitCodeProcess on windows
Tested on linux, windows (10, broken on XP), darwin, openbsd, freebsd
Regarding WinXP, this is failing because of PROCESS_QUERY_LIMITED_INFORMATION being introduced in in Vista. Calling
windows.OpenProcesswithwindows.PROCESS_QUERY_INFORMATIONworks properly on WinXP (hinting that every calls to OpenProcess with PROCESS_QUERY_LIMITED_INFORMATION in gopsutil fail on WinXP). Handling this (opening process with right parameter according to Windows version) would complicate a little bit the code in process_window.go (while being prudent not too slow down gopsutil functions), I'm not sure if we should bother so much about WinXP now that it's deprecated for quite a few years.