Have a real fixed HostID on Linux #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Linux, most golang programs do not run as root (or at least, they should not), by default, the kernels uses strict permissions, so most userland programs cannot read `/sys/class/dmi/id/product_uuid`. However, programs such as Consul are relying on it to get fixed IDs, instead they have a different ID on each boot. We propose to use `/etc/machine-id` as fallback https://www.freedesktop.org/software/systemd/man/machine-id.html In order to fix this, this patch does the following: - if `/sys/class/dmi/id/product_uuid` can be read, use it for HostID - else if `/etc/machine-id` exists and has 32 chars, use it and add '-' to have the same format as product_uuid - finally, if notthing works, use the `kernel.random.boot_id` This will greatly increase the number of programs having correct behaviour when those rely on having a fixed HostID. This will fix the following issues: - shirou#350 - hashicorp/consul#4741
Lomanic
reviewed
Nov 6, 2018
|
@Lomanic yes, but this case is already properly handled with error management below. What I mean is, this case (file not being readable is not the exception: some weird kernel config or unusual arch), but the rule (I mean, only programs running as root can use it, which in 2018 should be the exception, not the rule) |
pierresouchay
force-pushed
the
host_id_fixed_on_linux
branch
from
98c39f5
to
890eb80
Compare
|
@Lomanic Thank you for the review |
This was referenced Nov 6, 2018
|
LGTM |
|
Wow, Great! Your are thinking backward compatibility so much! |
|
@shirou Thank you! Do you think you might release a new version, so I can fix the bug in Consul by updating this library? Kind Regards |
|
Releases are once per month, following calver like Ubuntu, see Tag semantics |
pierresouchay
added a commit
to pierresouchay/consul
that referenced
this pull request
Nov 8, 2018
Bump `shirou/gopsutil` to include shirou/gopsutil#603 This will allow to have consistent node-id even when machine is reinstalled when using `"disable_host_node_id": false` It will fix hashicorp#4914 and allow having the same node-id even when reinstalling a node from scratch. However, it is only compatible with a single OS (installing to Windows will change the node-id, but it seems acceptable).
|
+1 |
mkeeler
pushed a commit
to hashicorp/consul
that referenced
this pull request
Jan 10, 2019
…4926) Bump `shirou/gopsutil` to include shirou/gopsutil#603 This will allow to have consistent node-id even when machine is reinstalled when using `"disable_host_node_id": false` It will fix #4914 and allow having the same node-id even when reinstalling a node from scratch. However, it is only compatible with a single OS (installing to Windows will change the node-id, but it seems acceptable).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Linux, most golang programs do not run as root (or at least, they should not),
by default, the kernels uses strict permissions, so most userland programs cannot
read
/sys/class/dmi/id/product_uuid. However, programs such as Consul are relyingon it to get fixed IDs, instead they have a different ID on each boot.
We propose to use
/etc/machine-idas fallback https://www.freedesktop.org/software/systemd/man/machine-id.htmlIn order to fix this, this patch does the following:
/sys/class/dmi/id/product_uuidcan be read, use it for HostID/etc/machine-idexists and has 32 chars, use it and add '-' to have the same format as product_uuidkernel.random.boot_idThis will greatly increase the number of programs having correct behaviour when
those rely on having a fixed HostID.
This will fix the following issues: