Improve /proc/net/dev parsing to include all edge cases #357
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some old Linux kernels /proc/net/dev has the following format:
This pull request (and commit respectively) broke the parsing of similar formats (where there is no space after ":"):
#317
654255b
I have improved the parsing a bit, so that all cases are handled properly, i.e:
eth1: bytes
eth1:bytes
eth1:0:bytes
Also created a test for all three cases.