Refresh boot time #1616
Closed
Refresh boot time #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the RefreshBootTimeCache function, allowing users to manually refresh the cached boot time if they are using the `enableBootTimeCache` feature.
This commit adds the RefreshBootTimeCache function, allowing users to manually refresh the cached boot time if they are using the `enableBootTimeCache` feature.
braydonk
force-pushed
the
refresh_boot_time
branch
from
796962c to
f6350ce
Compare
|
I think the same could be accomplished with the following code on a library user side. I don't think it is necessary to add a new API. host.EnableBootTimeCache(false)
defer host.EnableBootTimeCache(true)
BootTimeWithContext(ctx) |
That would be better if it was possible, but BootTimeWithContext is internal. So I don't see any way on the user side to only read boot time once. |
|
I will work on an alternative PR that instead factors boot time into the common package and provides entrypoints so that your suggestion is possible. |
|
package main
import (
"context"
"fmt"
"github.com/shirou/gopsutil/v3/host"
)
func main() {
host.EnableBootTimeCache(false)
defer host.EnableBootTimeCache(true)
fmt.Println(host.BootTimeWithContext(context.Background()))
} |
|
Closing in favour of #1618 |
|
Ah okay so using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function to
processandhostto manually refresh the cached boot time value. This is very helpful in scenarios where you are reading all the processes on the system at a given time, want the performance gains of using the boot time cache, but want to update the cached boot time when you read all the processes.