Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump shipwright-builds dependency to v0.14.0 #238

Merged

Conversation

ayushsatyam146
Copy link
Contributor

@ayushsatyam146 ayushsatyam146 commented Jan 3, 2025

Changes

Submitter Checklist

  • Includes tests if functionality changed/was added
  • Includes docs if changes are user-facing
  • Set a kind label on this PR
  • Release notes block has been filled in, or marked NONE

See the contributor guide
for details on coding conventions, github and prow interactions, and the code review process.

Release Notes

Bumping github.com/shipwright-io/build to v0.14.0

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 3, 2025
@SaschaSchwarze0 SaschaSchwarze0 added this to the release-v0.15.0 milestone Jan 6, 2025
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign your commit.

@ayushsatyam146
Copy link
Contributor Author

@SaschaSchwarze0 I signed the commit

@SaschaSchwarze0
Copy link
Member

@SaschaSchwarze0 I signed the commit

@ayushsatyam146 please click on the red DCO link. There is a mis-match on the email address.

@ayushsatyam146 ayushsatyam146 force-pushed the builds-0.14-bump branch 2 times, most recently from 261ddec to b834f9c Compare January 6, 2025 16:09
@ayushsatyam146
Copy link
Contributor Author

@SaschaSchwarze0 I signed the commit

@ayushsatyam146 please click on the red DCO link. There is a mis-match on the email address.

Sorry for the confusion @SaschaSchwarze0. I have resolved the DCO issue now.

Copy link
Member

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jan 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2025
Copy link
Member

@SaschaSchwarze0 SaschaSchwarze0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2025
@SaschaSchwarze0 SaschaSchwarze0 added the kind/dependency-change Categorizes issue or PR as related to changing dependencies label Jan 6, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 31b8208 into shipwright-io:main Jan 6, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/dependency-change Categorizes issue or PR as related to changing dependencies lgtm Indicates that a PR is ready to be merged. release-note size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants