Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#261: Import of Evented from Utils set instead of global scope #260

Closed
wants to merge 1 commit into from
Closed

#261: Import of Evented from Utils set instead of global scope #260

wants to merge 1 commit into from

Conversation

satanTime
Copy link

When building library through webpack there're 2 global dependencies of tether.js on TetherBase and Evented, however Evented is part of TetherBase.Utils and we can import it from there.

Without fix import code looks like:

global.TetherBase = require('exports-loader?TetherBase!./node_modules/tether/src/js/utils.js');
Object.assign(global, global.TetherBase.Utils);
global.Tether = require('exports-loader?Tether!./node_modules/tether/src/js/tether.js');

With fix

global.TetherBase = require('exports-loader?TetherBase!./node_modules/tether/src/js/utils.js');
global.Tether = require('exports-loader?Tether!./node_modules/tether/src/js/tether.js');

@satanTime satanTime changed the title Import of Evented from Utils set instead of global scope #261: Import of Evented from Utils set instead of global scope May 19, 2017
@RobbieTheWagner
Copy link
Member

We're now importing Evented as a separate class, so I believe this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants