Remove classes when set to false

Fixes #253
shipshapecode · Sep 28, 2019 · ed4d46f · ed4d46f
1 parent 81b8ba2
commit ed4d46f
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 1 deletion.
diff --git a/src/js/tether.js b/src/js/tether.js
@@ -112,7 +112,10 @@ class TetherClass extends Evented {
 
   getClass(key = '') {
     const { classes } = this.options;
-    if (typeof classes !== 'undefined' && classes[key]) {
+    if (typeof classes !== 'undefined' && typeof classes[key] !== 'undefined') {
+      if (classes[key] === false) {
+        return '';
+      }
       return this.options.classes[key];
     } else if (this.options.classPrefix) {
       return `${this.options.classPrefix}-${key}`;

diff --git a/test/unit/tether.spec.js b/test/unit/tether.spec.js
@@ -136,5 +136,39 @@ describe('Tether', () => {
       expect(element.classList.length, 'element - destroy sets classes back to initial state').toEqual(1);
       expect(target.classList.length, 'target - destroy sets classes back to initial state').toEqual(1);
     });
+
+    it('removes classes when false', () => {
+      expect(element.classList.length, 'element - only one class').toEqual(1);
+      expect(target.classList.length, 'target - only one class').toEqual(1);
+      const tether = new Tether({
+        element: '.element',
+        target: '.target',
+        attachment: 'top left',
+        targetAttachment: 'top right',
+        classes: {
+          element: false,
+          enabled: false,
+          target: false
+        }
+      });
+
+      tether.enable();
+
+      expect(element.classList.length, 'element - classes added').toEqual(10);
+      expect(element).not.toHaveClass('tether-element');
+      expect(element).not.toHaveClass('tether-enabled');
+
+      expect(target.classList.length, 'target - classes added').toEqual(10);
+      expect(target).not.toHaveClass('tether-target');
+      expect(element).not.toHaveClass('tether-enabled');
+
+      expect(tether.getClass('element')).toBe('');
+      expect(tether.getClass('target')).toBe('');
+
+      tether.destroy();
+
+      expect(element.classList.length, 'element - destroy sets classes back to initial state').toEqual(1);
+      expect(target.classList.length, 'target - destroy sets classes back to initial state').toEqual(1);
+    });
   });
 });